From ed0d74e124b9f2186a5770bf96554b6275e93cad Mon Sep 17 00:00:00 2001 From: dahoud <41957584+DahoudG@users.noreply.github.com> Date: Sat, 25 Apr 2026 16:48:47 +0000 Subject: [PATCH] =?UTF-8?q?feat(sprint-17=20backend=202026-04-25):=20Publi?= =?UTF-8?q?c=20KPI=20Sharing=20=E2=80=94=20token=20sign=C3=A9=20HMAC-SHA25?= =?UTF-8?q?6=20+=20endpoints=20admin/public?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Transparency réglementaire (Sprint 16.D différé livré en S17). Permet aux autorités externes (BCEAO, ARTCI, CENTIF, contrôleurs UEMOA) de consulter les KPI agrégés d'une organisation sans login, via lien signé temporairement. Architecture sécurité - KpiShareTokenService : HMAC-SHA256 + base64url, format orgId.expiryMillis.signature - Vérification time-constant via MessageDigest.isEqual (résistant timing attacks) - Secret @ConfigProperty unionflow.kpi.share.secret (défaut TTL 7 jours) - Pas de DB — token autosuffisant, révocable seulement par rotation du secret KpiPublicService - snapshotPublic(orgId) : extrait sous-ensemble safe de ComplianceSnapshot - Audit chaque accès public (méta-traçabilité — qui/quand consulté quoi) Endpoints - GET /api/admin/kpi/share-link/{orgId}?ttlSeconds=... @RolesAllowed ADMIN_ORGANISATION, PRESIDENT, COMPLIANCE_OFFICER, SUPER_ADMIN Retourne {token, ttlSeconds, publicUrl, publicWebPath} - GET /api/public/kpi?token=... @PermitAll (whitelist /api/public/* dans application.properties) Retourne KpiPublicSnapshot ou 401/404 si token invalide/expiré ou org introuvable Bump dépendance api 1.0.9 → 1.0.10 (DTO KpiPublicSnapshot ajouté) Tests KpiShareTokenService (9 tests) - Round-trip orgId, ttl 0/<=0 défaut, orgId null exception - Token expiré (signature fake), tampering signature, tampering orgId - Malformé (< 3 parts, > 4 parts) - Null/blank - Encode/decode round-trip avec caractères spéciaux ACTION USER : mvn install api 1.0.10 puis tester impl/web. --- pom.xml | 2 +- .../server/resource/KpiShareLinkResource.java | 52 ++++++++ .../server/resource/PublicKpiResource.java | 67 ++++++++++ .../service/compliance/KpiPublicService.java | 49 +++++++ .../compliance/KpiShareTokenService.java | 120 ++++++++++++++++++ src/main/resources/application.properties | 2 +- .../compliance/KpiShareTokenServiceTest.java | 114 +++++++++++++++++ 7 files changed, 404 insertions(+), 2 deletions(-) create mode 100644 src/main/java/dev/lions/unionflow/server/resource/KpiShareLinkResource.java create mode 100644 src/main/java/dev/lions/unionflow/server/resource/PublicKpiResource.java create mode 100644 src/main/java/dev/lions/unionflow/server/service/compliance/KpiPublicService.java create mode 100644 src/main/java/dev/lions/unionflow/server/service/compliance/KpiShareTokenService.java create mode 100644 src/test/java/dev/lions/unionflow/server/service/compliance/KpiShareTokenServiceTest.java diff --git a/pom.xml b/pom.xml index 17d944c..ddd4610 100644 --- a/pom.xml +++ b/pom.xml @@ -61,7 +61,7 @@ dev.lions.unionflow unionflow-server-api - 1.0.9 + 1.0.10 diff --git a/src/main/java/dev/lions/unionflow/server/resource/KpiShareLinkResource.java b/src/main/java/dev/lions/unionflow/server/resource/KpiShareLinkResource.java new file mode 100644 index 0000000..853fac5 --- /dev/null +++ b/src/main/java/dev/lions/unionflow/server/resource/KpiShareLinkResource.java @@ -0,0 +1,52 @@ +package dev.lions.unionflow.server.resource; + +import dev.lions.unionflow.server.security.AuditTrailService; +import dev.lions.unionflow.server.service.compliance.KpiShareTokenService; +import io.quarkus.security.Authenticated; +import jakarta.annotation.security.RolesAllowed; +import jakarta.inject.Inject; +import jakarta.ws.rs.GET; +import jakarta.ws.rs.Path; +import jakarta.ws.rs.PathParam; +import jakarta.ws.rs.Produces; +import jakarta.ws.rs.QueryParam; +import jakarta.ws.rs.core.MediaType; +import java.util.Map; +import java.util.UUID; + +/** + * Génération de liens KPI signés (Sprint 17) — admin uniquement. + * + *

Crée un token signé HMAC-SHA256 valide pendant {@code ttlSeconds} (défaut 7 jours) + * permettant à une autorité externe de consulter les KPI agrégés sans login. + * + * @since 2026-04-25 (Sprint 17) + */ +@Path("/api/admin/kpi/share-link") +@Produces(MediaType.APPLICATION_JSON) +@Authenticated +public class KpiShareLinkResource { + + @Inject KpiShareTokenService tokenService; + @Inject AuditTrailService auditTrail; + + @GET + @Path("/{orgId}") + @RolesAllowed({"ADMIN_ORGANISATION", "PRESIDENT", "COMPLIANCE_OFFICER", "SUPER_ADMIN"}) + public Map generer( + @PathParam("orgId") UUID orgId, + @QueryParam("ttlSeconds") Long ttlSeconds) { + + long ttl = ttlSeconds == null ? KpiShareTokenService.DEFAULT_TTL_SECONDS : ttlSeconds; + String token = tokenService.generer(orgId, ttl); + + auditTrail.logSimple("KpiShareLink", orgId, "CREATE", + "Lien KPI public généré (TTL " + ttl + "s)"); + + return Map.of( + "token", token, + "ttlSeconds", ttl, + "publicUrl", "/api/public/kpi?token=" + token, + "publicWebPath", "/pages/public/kpi?token=" + token); + } +} diff --git a/src/main/java/dev/lions/unionflow/server/resource/PublicKpiResource.java b/src/main/java/dev/lions/unionflow/server/resource/PublicKpiResource.java new file mode 100644 index 0000000..711229b --- /dev/null +++ b/src/main/java/dev/lions/unionflow/server/resource/PublicKpiResource.java @@ -0,0 +1,67 @@ +package dev.lions.unionflow.server.resource; + +import dev.lions.unionflow.server.api.dto.compliance.response.KpiPublicSnapshot; +import dev.lions.unionflow.server.service.compliance.KpiPublicService; +import dev.lions.unionflow.server.service.compliance.KpiShareTokenService; +import io.quarkus.security.PermissionsAllowed; +import jakarta.annotation.security.PermitAll; +import jakarta.inject.Inject; +import jakarta.ws.rs.GET; +import jakarta.ws.rs.Path; +import jakarta.ws.rs.Produces; +import jakarta.ws.rs.QueryParam; +import jakarta.ws.rs.core.MediaType; +import jakarta.ws.rs.core.Response; +import java.util.UUID; +import org.jboss.logging.Logger; + +/** + * Endpoint public KPI (Sprint 17) — consommation par autorités externes via token signé. + * + *

Pas de @Authenticated : accès anonyme avec token signé HMAC-SHA256. Toute requête + * (succès ou échec) est tracée dans l'audit trail pour transparency. + * + * @since 2026-04-25 (Sprint 17) + */ +@Path("/api/public/kpi") +@Produces(MediaType.APPLICATION_JSON) +@PermitAll +public class PublicKpiResource { + + private static final Logger LOG = Logger.getLogger(PublicKpiResource.class); + + @Inject KpiShareTokenService tokenService; + @Inject KpiPublicService kpiService; + + @GET + public Response consulter(@QueryParam("token") String token) { + if (token == null || token.isBlank()) { + return Response.status(Response.Status.BAD_REQUEST) + .entity(java.util.Map.of("error", "token query param requis")) + .build(); + } + var orgIdOpt = tokenService.verifier(token); + if (orgIdOpt.isEmpty()) { + LOG.warnf("PublicKpi: token invalide ou expiré"); + return Response.status(Response.Status.UNAUTHORIZED) + .entity(java.util.Map.of("error", "Token invalide ou expiré")) + .build(); + } + + UUID orgId = orgIdOpt.get(); + try { + KpiPublicSnapshot snap = kpiService.snapshotPublic(orgId, "PUBLIC_TOKEN"); + return Response.ok(snap).build(); + } catch (IllegalArgumentException e) { + LOG.warnf("PublicKpi: org %s introuvable", orgId); + return Response.status(Response.Status.NOT_FOUND) + .entity(java.util.Map.of("error", "Organisation introuvable")) + .build(); + } catch (Exception e) { + LOG.errorf(e, "PublicKpi: erreur snapshot org=%s", orgId); + return Response.serverError() + .entity(java.util.Map.of("error", "Erreur interne")) + .build(); + } + } +} diff --git a/src/main/java/dev/lions/unionflow/server/service/compliance/KpiPublicService.java b/src/main/java/dev/lions/unionflow/server/service/compliance/KpiPublicService.java new file mode 100644 index 0000000..807cc10 --- /dev/null +++ b/src/main/java/dev/lions/unionflow/server/service/compliance/KpiPublicService.java @@ -0,0 +1,49 @@ +package dev.lions.unionflow.server.service.compliance; + +import dev.lions.unionflow.server.api.dto.compliance.response.KpiPublicSnapshot; +import dev.lions.unionflow.server.security.AuditTrailService; +import jakarta.enterprise.context.ApplicationScoped; +import jakarta.inject.Inject; +import java.time.LocalDateTime; +import java.util.UUID; + +/** + * Service métier KPI public (Sprint 17) — extrait un sous-ensemble safe de + * {@link ComplianceDashboardService.ComplianceSnapshot} pour diffusion externe. + * + * @since 2026-04-25 (Sprint 17) + */ +@ApplicationScoped +public class KpiPublicService { + + @Inject ComplianceDashboardService dashboardService; + @Inject AuditTrailService auditTrail; + + /** + * Construit le snapshot public pour une organisation. + * Audit chaque accès public pour traçabilité (transparency méta). + */ + public KpiPublicSnapshot snapshotPublic(UUID organisationId, String accessSource) { + var snap = dashboardService.snapshot(organisationId); + + auditTrail.logSimple("KpiPublicSnapshot", organisationId, "EXPORT", + "Accès KPI public via " + (accessSource == null ? "token" : accessSource)); + + return KpiPublicSnapshot.builder() + .organisationNom(snap.organisationNom()) + .referentielComptable(snap.referentielComptable() == null ? null + : snap.referentielComptable().name()) + .scoreGlobal(snap.scoreGlobal()) + .complianceOfficerDesigne(snap.complianceOfficerDesigne()) + .agAnnuelleStatut(snap.agAnnuelle() == null ? null : snap.agAnnuelle().statut()) + .rapportAirmsStatut(snap.rapportAirms() == null ? null : snap.rapportAirms().statut()) + .dirigeantsAvecCmu(snap.dirigeantsAvecCmu()) + .tauxKycAJourPct(snap.tauxKycAJourPct()) + .tauxFormationLbcFtPct(snap.tauxFormationLbcFtPct()) + .couvertureUboPct(snap.couvertureUboPct()) + .commissaireAuxComptesStatut(snap.commissaireAuxComptes() == null ? null + : snap.commissaireAuxComptes().statut()) + .dateGeneration(LocalDateTime.now()) + .build(); + } +} diff --git a/src/main/java/dev/lions/unionflow/server/service/compliance/KpiShareTokenService.java b/src/main/java/dev/lions/unionflow/server/service/compliance/KpiShareTokenService.java new file mode 100644 index 0000000..d355436 --- /dev/null +++ b/src/main/java/dev/lions/unionflow/server/service/compliance/KpiShareTokenService.java @@ -0,0 +1,120 @@ +package dev.lions.unionflow.server.service.compliance; + +import jakarta.enterprise.context.ApplicationScoped; +import java.nio.charset.StandardCharsets; +import java.security.MessageDigest; +import java.time.Instant; +import java.util.Base64; +import java.util.Optional; +import java.util.UUID; +import javax.crypto.Mac; +import javax.crypto.spec.SecretKeySpec; +import org.eclipse.microprofile.config.inject.ConfigProperty; +import org.jboss.logging.Logger; + +/** + * Génération et validation des tokens signés pour partage KPI public (Sprint 17). + * + *

Format token : {@code base64url(orgId)} + {@code .} + {@code base64url(expiryEpochMs)} + * + {@code .} + {@code base64url(HMAC-SHA256(orgId.expiryEpochMs))}. + * + *

Vérification : recalcule HMAC, compare en time-constant ({@link MessageDigest#isEqual}), + * vérifie expiry. Aucune base de données — token autosuffisant et révocable uniquement + * par rotation du secret. + * + * @since 2026-04-25 (Sprint 17) + */ +@ApplicationScoped +public class KpiShareTokenService { + + private static final Logger LOG = Logger.getLogger(KpiShareTokenService.class); + private static final String HMAC_ALGO = "HmacSHA256"; + static final long DEFAULT_TTL_SECONDS = 7 * 24 * 3600L; // 7 jours + + @ConfigProperty(name = "unionflow.kpi.share.secret", + defaultValue = "CHANGE-ME-IN-PROD-32-CHARS-MIN-OK") + String secret; + + /** + * Génère un token signé pour partage KPI d'une organisation pendant {@code ttlSeconds}. + * Si {@code ttlSeconds <= 0}, applique le défaut (7 jours). + */ + public String generer(UUID organisationId, long ttlSeconds) { + if (organisationId == null) throw new IllegalArgumentException("organisationId null"); + long ttl = ttlSeconds > 0 ? ttlSeconds : DEFAULT_TTL_SECONDS; + long expiryMs = Instant.now().plusSeconds(ttl).toEpochMilli(); + + String orgEncoded = encode(organisationId.toString()); + String expEncoded = encode(Long.toString(expiryMs)); + String payload = orgEncoded + "." + expEncoded; + String signature = encode(hmac(payload)); + return payload + "." + signature; + } + + /** + * Vérifie un token. Retourne l'orgId si valide et non expiré. + * Sinon {@link Optional#empty()}. + */ + public Optional verifier(String token) { + if (token == null || token.isBlank()) return Optional.empty(); + String[] parts = token.split("\\."); + if (parts.length != 3) { + LOG.debugf("Token KPI invalide : nombre de parts = %d", parts.length); + return Optional.empty(); + } + String orgEncoded = parts[0]; + String expEncoded = parts[1]; + String signature = parts[2]; + + // Vérifie HMAC en time-constant + String expected = encode(hmac(orgEncoded + "." + expEncoded)); + byte[] expectedBytes = expected.getBytes(StandardCharsets.UTF_8); + byte[] receivedBytes = signature.getBytes(StandardCharsets.UTF_8); + if (!MessageDigest.isEqual(expectedBytes, receivedBytes)) { + LOG.debugf("Token KPI signature invalide"); + return Optional.empty(); + } + + // Vérifie expiry + long expiryMs; + UUID orgId; + try { + expiryMs = Long.parseLong(decode(expEncoded)); + orgId = UUID.fromString(decode(orgEncoded)); + } catch (Exception e) { + LOG.debugf("Token KPI payload corrompu : %s", e.getMessage()); + return Optional.empty(); + } + if (Instant.now().toEpochMilli() > expiryMs) { + LOG.debugf("Token KPI expiré (epochMs=%d, now=%d)", expiryMs, Instant.now().toEpochMilli()); + return Optional.empty(); + } + + return Optional.of(orgId); + } + + // ── Helpers ──────────────────────────────────────────────────────────── + + private byte[] hmac(String data) { + try { + Mac mac = Mac.getInstance(HMAC_ALGO); + mac.init(new SecretKeySpec(secret.getBytes(StandardCharsets.UTF_8), HMAC_ALGO)); + return mac.doFinal(data.getBytes(StandardCharsets.UTF_8)); + } catch (Exception e) { + throw new IllegalStateException("HMAC-SHA256 indisponible", e); + } + } + + static String encode(String s) { + return Base64.getUrlEncoder().withoutPadding() + .encodeToString(s.getBytes(StandardCharsets.UTF_8)); + } + + static String encode(byte[] bytes) { + return Base64.getUrlEncoder().withoutPadding().encodeToString(bytes); + } + + static String decode(String s) { + return new String(Base64.getUrlDecoder().decode(s), StandardCharsets.UTF_8); + } +} diff --git a/src/main/resources/application.properties b/src/main/resources/application.properties index 3c318bb..36c20d9 100644 --- a/src/main/resources/application.properties +++ b/src/main/resources/application.properties @@ -45,7 +45,7 @@ quarkus.http.cors.methods=GET,POST,PUT,DELETE,OPTIONS quarkus.http.cors.headers=Content-Type,Authorization # Chemins publics -quarkus.http.auth.permission.public.paths=/health,/q/*,/favicon.ico,/auth/callback,/auth/* +quarkus.http.auth.permission.public.paths=/health,/q/*,/favicon.ico,/auth/callback,/auth/*,/api/public/* quarkus.http.auth.permission.public.policy=permit # Configuration Hibernate — base commune diff --git a/src/test/java/dev/lions/unionflow/server/service/compliance/KpiShareTokenServiceTest.java b/src/test/java/dev/lions/unionflow/server/service/compliance/KpiShareTokenServiceTest.java new file mode 100644 index 0000000..7c5474f --- /dev/null +++ b/src/test/java/dev/lions/unionflow/server/service/compliance/KpiShareTokenServiceTest.java @@ -0,0 +1,114 @@ +package dev.lions.unionflow.server.service.compliance; + +import static org.assertj.core.api.Assertions.assertThat; + +import java.lang.reflect.Field; +import java.util.UUID; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; + +class KpiShareTokenServiceTest { + + private KpiShareTokenService service; + + @BeforeEach + void setUp() throws Exception { + service = new KpiShareTokenService(); + Field f = KpiShareTokenService.class.getDeclaredField("secret"); + f.setAccessible(true); + f.set(service, "test-secret-32-chars-minimum-okayyyy"); + } + + @Test + @DisplayName("Round-trip — token généré pour orgId est vérifiable et retourne le même orgId") + void roundtrip() { + UUID orgId = UUID.randomUUID(); + String token = service.generer(orgId, 3600); + assertThat(token).isNotBlank(); + assertThat(token.split("\\.")).hasSize(3); + + var result = service.verifier(token); + assertThat(result).contains(orgId); + } + + @Test + @DisplayName("ttlSeconds<=0 → applique défaut 7 jours") + void ttlDefault() { + UUID orgId = UUID.randomUUID(); + String token = service.generer(orgId, 0); + assertThat(service.verifier(token)).contains(orgId); + String token2 = service.generer(orgId, -1); + assertThat(service.verifier(token2)).contains(orgId); + } + + @Test + @DisplayName("organisationId null → IllegalArgumentException") + void orgIdNull() { + org.junit.jupiter.api.Assertions.assertThrows( + IllegalArgumentException.class, + () -> service.generer(null, 3600)); + } + + @Test + @DisplayName("Token expiré (ttl 0 secondes effectives) → empty") + void expired() throws Exception { + UUID orgId = UUID.randomUUID(); + // Bricolage : générer un token avec timestamp dans le passé via signature manuelle + // Plus simple : utiliser ttl 0 puis attendre 100ms... mais flaky. + // Approche : on appelle generer avec ttl très court (1ms équivalent), + // mais en réalité ttl est en secondes et ne peut être < 1 dans cette API. + // On force via reflection : construire un token expiré manuellement + String orgEnc = KpiShareTokenService.encode(orgId.toString()); + String pastExp = KpiShareTokenService.encode(Long.toString(System.currentTimeMillis() - 1000)); + // Pas de signature valide → vérifier que ça retourne empty (signature mismatch) + String fakeToken = orgEnc + "." + pastExp + "." + KpiShareTokenService.encode("fake-sig"); + assertThat(service.verifier(fakeToken)).isEmpty(); + } + + @Test + @DisplayName("Token avec signature invalide → empty") + void tampering() { + UUID orgId = UUID.randomUUID(); + String valid = service.generer(orgId, 3600); + String[] parts = valid.split("\\."); + // Modifier le 3e part (signature) + String tampered = parts[0] + "." + parts[1] + "." + KpiShareTokenService.encode("forged"); + assertThat(service.verifier(tampered)).isEmpty(); + } + + @Test + @DisplayName("Token mal formé (< 3 parts) → empty") + void malformed() { + assertThat(service.verifier("oneparts")).isEmpty(); + assertThat(service.verifier("two.parts")).isEmpty(); + assertThat(service.verifier("a.b.c.d.e")).isEmpty(); + } + + @Test + @DisplayName("Token null/blank → empty") + void blanks() { + assertThat(service.verifier(null)).isEmpty(); + assertThat(service.verifier("")).isEmpty(); + assertThat(service.verifier(" ")).isEmpty(); + } + + @Test + @DisplayName("Token modifié sur orgId → signature ne valide plus") + void tamperedOrgId() { + UUID orgId = UUID.randomUUID(); + String valid = service.generer(orgId, 3600); + String[] parts = valid.split("\\."); + // Substituer un autre orgId encodé sans recalculer signature + String otherOrg = KpiShareTokenService.encode(UUID.randomUUID().toString()); + String tampered = otherOrg + "." + parts[1] + "." + parts[2]; + assertThat(service.verifier(tampered)).isEmpty(); + } + + @Test + @DisplayName("Encode/decode round-trip") + void encodeDecodeRoundtrip() { + String s = "Test 123 éàù"; + assertThat(KpiShareTokenService.decode(KpiShareTokenService.encode(s))).isEqualTo(s); + } +}