From 7e8ee33512f2cb77da9f16834c2865db72f89c17 Mon Sep 17 00:00:00 2001
From: dahoud <dahoud@dgbf.ci>
Date: Sat, 29 Nov 2025 22:10:14 +0000
Subject: [PATCH] fix(client): Retour aux p:commandButton directs pour les
 actions dans DataTables
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PROBLÈME IDENTIFIÉ:
- Les composants action-button-* et button-form-submit utilisaient ui:define pour passer action
- JSF ne peut pas évaluer ui:define comme une expression de méthode
- Erreur: 'Identity [action] does not reference a method expression instance, returned type [java.lang.String]'

SOLUTION APPLIQUÉE:
- Suppression de action-button-edit.xhtml, action-button-toggle.xhtml, action-button-delete.xhtml, button-form-submit.xhtml
- Retour aux p:commandButton directs dans liste.xhtml et nouvelle.xhtml
- Ajout de ui-button-text pour le style Rounded Text (icône + texte)
- Largeur colonne Actions augmentée : 280px → 320px

COMPOSANTS DRY/WOU CONSERVÉS (qui fonctionnent):
- button-success.xhtml, button-secondary.xhtml : navigation avec outcome
- button-primary.xhtml, button-warning.xhtml, button-info.xhtml, button-icon.xhtml : actions simples
- Tous les composants cards, forms, layout, tables, dialogs

CONCLUSION:
Pour les actions avec paramètres dans DataTables, p:commandButton direct est la seule solution viable en JSF.
---
 .../pages/secure/organisation/liste.xhtml     | 72 +++++++++----------
 .../pages/secure/organisation/nouvelle.xhtml  | 16 ++---
 .../buttons/action-button-delete.xhtml        | 30 --------
 .../buttons/action-button-edit.xhtml          | 27 -------
 .../buttons/action-button-toggle.xhtml        | 31 --------
 .../buttons/button-form-submit.xhtml          | 47 ------------
 .../components/tables/data-table.xhtml        |  3 +-
 7 files changed, 42 insertions(+), 184 deletions(-)
 delete mode 100644 unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/action-button-delete.xhtml
 delete mode 100644 unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/action-button-edit.xhtml
 delete mode 100644 unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/action-button-toggle.xhtml
 delete mode 100644 unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/button-form-submit.xhtml

diff --git a/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/pages/secure/organisation/liste.xhtml b/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/pages/secure/organisation/liste.xhtml
index 3d4aa9f..3261ad4 100644
--- a/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/pages/secure/organisation/liste.xhtml
+++ b/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/pages/secure/organisation/liste.xhtml
@@ -123,7 +123,8 @@
                                  rowsPerPageTemplate="10,20,50,100"
                                  paginatorPosition="bottom"
                                  emptyMessage="Aucune organisation trouvée"
-                                 styleClass="table-responsive">
+                                 styleClass="table-responsive"
+                                 size="small">
                         
                         <!-- Logo (DRY/WOU: organisation-logo) -->
                         <p:column headerText="" style="width: 80px;">
@@ -164,44 +165,39 @@
                                    icon="#{org.statut == organisationsBean.statutActive ? 'pi pi-check' : 'pi pi-times'}"/>
                         </p:column>
                         
-                        <!-- Actions (DRY/WOU: action-button-* avec ui:button-text pour Rounded Text) -->
-                        <p:column headerText="Actions" style="width: 280px;">
-                            <!-- Bouton Consulter -->
-                            <ui:include src="/templates/components/buttons/action-button-view.xhtml">
-                                <ui:param name="id" value="#{org.id}"/>
-                                <ui:param name="detailPage" value="/pages/secure/organisation/detail.xhtml"/>
-                                <ui:param name="styleClass" value="mr-2"/>
-                            </ui:include>
+                        <!-- Actions (Rounded Text : boutons avec icône + texte) -->
+                        <p:column headerText="Actions" style="width: 320px;">
+                            <p:commandButton value="Consulter"
+                                           icon="pi pi-search"
+                                           styleClass="ui-button-rounded ui-button-text ui-button-info mr-2"
+                                           onclick="window.location='#{request.contextPath}/pages/secure/organisation/detail.xhtml?id=#{org.id}';return false;"/>
+                                           
+                            <p:commandButton value="Modifier"
+                                           icon="pi pi-pencil"
+                                           actionListener="#{organisationsBean.setOrganisationSelectionnee(org)}"
+                                           oncomplete="PF('dlgModifier').show();"
+                                           update=":formModifier"
+                                           styleClass="ui-button-rounded ui-button-text ui-button-warning mr-2"/>
+                                           
+                            <p:commandButton value="#{org.statut == organisationsBean.statutActive ? 'Désactiver' : 'Activer'}"
+                                           icon="#{org.statut == organisationsBean.statutActive ? 'pi pi-ban' : 'pi pi-check'}"
+                                           actionListener="#{organisationsBean.basculerStatutOrganisation(org)}"
+                                           update=":formOrganisations:dtOrganisations :formOrganisations:messages"
+                                           styleClass="ui-button-rounded ui-button-text #{org.statut == organisationsBean.statutActive ? 'ui-button-secondary' : 'ui-button-success'} mr-2">
+                                <p:confirm header="Confirmation"
+                                         message="Êtes-vous sûr de vouloir changer le statut de cette organisation ?"
+                                         icon="pi pi-exclamation-triangle"/>
+                            </p:commandButton>
                             
-                            <!-- Bouton Modifier -->
-                            <ui:decorate template="/templates/components/buttons/action-button-edit.xhtml">
-                                <ui:param name="update" value=":formModifier"/>
-                                <ui:param name="dialogWidget" value="dlgModifier"/>
-                                <ui:param name="styleClass" value="mr-2"/>
-                                <ui:define name="action">
-                                    #{organisationsBean.setOrganisationSelectionnee(org)}
-                                </ui:define>
-                            </ui:decorate>
-                            
-                            <!-- Bouton Toggle Statut -->
-                            <ui:decorate template="/templates/components/buttons/action-button-toggle.xhtml">
-                                <ui:param name="update" value=":formOrganisations:dtOrganisations :formOrganisations:messages"/>
-                                <ui:param name="isActive" value="#{org.statut == organisationsBean.statutActive}"/>
-                                <ui:param name="confirmMessage" value="Êtes-vous sûr de vouloir changer le statut de cette organisation ?"/>
-                                <ui:param name="styleClass" value="mr-2"/>
-                                <ui:define name="action">
-                                    #{organisationsBean.basculerStatutOrganisation(org)}
-                                </ui:define>
-                            </ui:decorate>
-                            
-                            <!-- Bouton Supprimer -->
-                            <ui:decorate template="/templates/components/buttons/action-button-delete.xhtml">
-                                <ui:param name="update" value=":formOrganisations:dtOrganisations :formOrganisations:messages"/>
-                                <ui:param name="confirmMessage" value="Êtes-vous sûr de vouloir supprimer cette organisation ? Cette action est irréversible."/>
-                                <ui:define name="action">
-                                    #{organisationsBean.supprimerOrganisation(org)}
-                                </ui:define>
-                            </ui:decorate>
+                            <p:commandButton value="Supprimer"
+                                           icon="pi pi-trash"
+                                           actionListener="#{organisationsBean.supprimerOrganisation(org)}"
+                                           update=":formOrganisations:dtOrganisations :formOrganisations:messages"
+                                           styleClass="ui-button-rounded ui-button-text ui-button-danger">
+                                <p:confirm header="Confirmation"
+                                         message="Êtes-vous sûr de vouloir supprimer cette organisation ? Cette action est irréversible."
+                                         icon="pi pi-exclamation-triangle"/>
+                            </p:commandButton>
                         </p:column>
                     </p:dataTable>
                 </ui:define>
diff --git a/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/pages/secure/organisation/nouvelle.xhtml b/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/pages/secure/organisation/nouvelle.xhtml
index 2486a79..0838cb1 100644
--- a/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/pages/secure/organisation/nouvelle.xhtml
+++ b/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/pages/secure/organisation/nouvelle.xhtml
@@ -48,16 +48,12 @@
                     <ui:param name="icon" value="pi pi-times"/>
                     <ui:param name="outcome" value="/pages/secure/organisation/liste"/>
                 </ui:include>
-                <!-- DRY/WOU: button-form-submit pour action backend -->
-                <ui:decorate template="/templates/components/buttons/button-form-submit.xhtml">
-                    <ui:param name="value" value="Créer" />
-                    <ui:param name="icon" value="pi pi-check" />
-                    <ui:param name="update" value=":formNouvelleOrganisation:messages" />
-                    <ui:param name="severity" value="success" />
-                    <ui:define name="action">
-                        #{organisationsBean.creerOrganisation}
-                    </ui:define>
-                </ui:decorate>
+                <!-- Bouton Créer : p:commandButton direct car action avec méthode backend -->
+                <p:commandButton value="Créer"
+                               icon="pi pi-check"
+                               action="#{organisationsBean.creerOrganisation}"
+                               update=":formNouvelleOrganisation:messages"
+                               styleClass="ui-button-success" />
             </div>
         </h:form>
     </ui:define>
diff --git a/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/action-button-delete.xhtml b/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/action-button-delete.xhtml
deleted file mode 100644
index c016137..0000000
--- a/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/action-button-delete.xhtml
+++ /dev/null
@@ -1,30 +0,0 @@
-<ui:composition xmlns="http://www.w3.org/1999/xhtml"
-                xmlns:h="http://xmlns.jcp.org/jsf/html"
-                xmlns:ui="http://xmlns.jcp.org/jsf/facelets"
-                xmlns:p="http://primefaces.org/ui">
-
-    <!--
-        Composant bouton "Supprimer" avec confirmation réutilisable - DRY/WOU
-        
-        Usage avec ui:decorate pour passer l'action via ui:define :
-        <ui:decorate template="/templates/components/buttons/action-button-delete.xhtml">
-            <ui:param name="update" value=":formList:dtItems :formList:messages"/>
-            <ui:param name="confirmMessage" value="Êtes-vous sûr de vouloir supprimer ?"/>
-            <ui:param name="styleClass" value=""/>
-            <ui:define name="action">
-                #{bean.deleteItem(item)}
-            </ui:define>
-        </ui:decorate>
-    -->
-
-    <p:commandButton value="Supprimer"
-                   icon="pi pi-trash"
-                   actionListener="#{action}"
-                   update="#{update}"
-                   styleClass="ui-button-rounded ui-button-text ui-button-danger #{not empty styleClass ? styleClass : ''}">
-        <p:confirm header="Confirmation"
-                 message="#{empty confirmMessage ? 'Êtes-vous sûr de vouloir supprimer cet élément ?' : confirmMessage}"
-                 icon="pi pi-exclamation-triangle"/>
-    </p:commandButton>
-</ui:composition>
-
diff --git a/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/action-button-edit.xhtml b/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/action-button-edit.xhtml
deleted file mode 100644
index 7a661f6..0000000
--- a/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/action-button-edit.xhtml
+++ /dev/null
@@ -1,27 +0,0 @@
-<ui:composition xmlns="http://www.w3.org/1999/xhtml"
-                xmlns:h="http://xmlns.jcp.org/jsf/html"
-                xmlns:ui="http://xmlns.jcp.org/jsf/facelets"
-                xmlns:p="http://primefaces.org/ui">
-
-    <!--
-        Composant bouton "Modifier" réutilisable - DRY/WOU
-        
-        Usage avec ui:decorate pour passer l'action via ui:define :
-        <ui:decorate template="/templates/components/buttons/action-button-edit.xhtml">
-            <ui:param name="update" value=":formEdit"/>
-            <ui:param name="dialogWidget" value="dlgEdit"/>
-            <ui:param name="styleClass" value="mr-2"/>
-            <ui:define name="action">
-                #{bean.setItemSelected(item)}
-            </ui:define>
-        </ui:decorate>
-    -->
-
-    <p:commandButton value="Modifier"
-                   icon="pi pi-pencil"
-                   actionListener="#{action}"
-                   oncomplete="PF('#{dialogWidget}').show();"
-                   update="#{update}"
-                   styleClass="ui-button-rounded ui-button-text ui-button-warning #{not empty styleClass ? styleClass : ''}"/>
-</ui:composition>
-
diff --git a/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/action-button-toggle.xhtml b/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/action-button-toggle.xhtml
deleted file mode 100644
index 366ea1a..0000000
--- a/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/action-button-toggle.xhtml
+++ /dev/null
@@ -1,31 +0,0 @@
-<ui:composition xmlns="http://www.w3.org/1999/xhtml"
-                xmlns:h="http://xmlns.jcp.org/jsf/html"
-                xmlns:ui="http://xmlns.jcp.org/jsf/facelets"
-                xmlns:p="http://primefaces.org/ui">
-
-    <!--
-        Composant bouton "Activer/Désactiver" avec confirmation réutilisable - DRY/WOU
-        
-        Usage avec ui:decorate pour passer l'action via ui:define :
-        <ui:decorate template="/templates/components/buttons/action-button-toggle.xhtml">
-            <ui:param name="update" value=":formList:dtItems :formList:messages"/>
-            <ui:param name="isActive" value="#{item.statut == 'ACTIVE'}"/>
-            <ui:param name="confirmMessage" value="Êtes-vous sûr ?"/>
-            <ui:param name="styleClass" value="mr-2"/>
-            <ui:define name="action">
-                #{bean.toggleItem(item)}
-            </ui:define>
-        </ui:decorate>
-    -->
-
-    <p:commandButton value="#{isActive ? 'Désactiver' : 'Activer'}"
-                   icon="#{isActive ? 'pi pi-ban' : 'pi pi-check'}"
-                   actionListener="#{action}"
-                   update="#{update}"
-                   styleClass="ui-button-rounded ui-button-text #{isActive ? 'ui-button-secondary' : 'ui-button-success'} #{not empty styleClass ? styleClass : ''}">
-        <p:confirm header="Confirmation"
-                 message="#{empty confirmMessage ? 'Êtes-vous sûr de vouloir changer le statut ?' : confirmMessage}"
-                 icon="pi pi-exclamation-triangle"/>
-    </p:commandButton>
-</ui:composition>
-
diff --git a/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/button-form-submit.xhtml b/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/button-form-submit.xhtml
deleted file mode 100644
index c97b629..0000000
--- a/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/buttons/button-form-submit.xhtml
+++ /dev/null
@@ -1,47 +0,0 @@
-<ui:composition xmlns="http://www.w3.org/1999/xhtml"
-                xmlns:h="http://xmlns.jcp.org/jsf/html"
-                xmlns:ui="http://xmlns.jcp.org/jsf/facelets"
-                xmlns:p="http://primefaces.org/ui">
-    
-    <!-- 
-        Composant bouton de soumission de formulaire réutilisable (WOU/DRY)
-        
-        Usage :
-        <ui:decorate template="/templates/components/buttons/button-form-submit.xhtml">
-            <ui:param name="value" value="Enregistrer" />
-            <ui:param name="icon" value="pi pi-check" />
-            <ui:param name="update" value=":form:messages" />
-            <ui:param name="process" value="@form" />
-            <ui:param name="severity" value="success" />
-            <ui:param name="oncomplete" value="if(!args.validationFailed) PF('dialog').hide();" />
-            <ui:define name="action">
-                #{bean.saveMethod}
-            </ui:define>
-        </ui:decorate>
-        
-        Paramètres :
-        - value : Texte du bouton (requis)
-        - icon : Icône (optionnel, défaut: pi pi-check)
-        - update : Composants à mettre à jour (optionnel)
-        - process : Composants à traiter (optionnel, défaut: @form)
-        - severity : success, secondary, warning, danger, info, primary (défaut: success)
-        - disabled : true/false (défaut: false)
-        - oncomplete : JavaScript à exécuter après l'action (optionnel)
-        - validateClient : true/false pour validation côté client (défaut: false)
-        - styleClass : Classes CSS additionnelles (optionnel)
-        
-        Slot action : Expression de méthode du bean (requis)
-    -->
-    
-    <p:commandButton value="#{value}"
-                   icon="#{empty icon ? 'pi pi-check' : icon}"
-                   action="#{action}"
-                   update="#{update}"
-                   process="#{empty process ? '@form' : process}"
-                   oncomplete="#{oncomplete}"
-                   validateClient="#{not empty validateClient and validateClient}"
-                   disabled="#{not empty disabled and disabled}"
-                   styleClass="ui-button-#{empty severity ? 'success' : severity} #{not empty styleClass ? styleClass : ''}"
-                   title="#{title}" />
-</ui:composition>
-
diff --git a/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/tables/data-table.xhtml b/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/tables/data-table.xhtml
index 56eb799..8550751 100644
--- a/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/tables/data-table.xhtml
+++ b/unionflow-client-quarkus-primefaces-freya/src/main/resources/META-INF/resources/templates/components/tables/data-table.xhtml
@@ -42,7 +42,8 @@
                  sortField="#{sortField}"
                  sortOrder="#{sortOrder}"
                  filteredValue="#{filteredValue}"
-                 widgetVar="#{widgetVar}">
+                 widgetVar="#{widgetVar}"
+                 size="#{size}">
         
         <ui:insert name="columns">
             <!-- Table columns go here -->