- DashboardWebSocketEndpoint: null-check on onMessage to avoid NPE when client sends null payload - ConversationParticipantTest.equalsHashCode: share Conversation+Membre instances (random UUIDs inside newConversation/newMembre were defeating equals) - MessageTest.equalsHashCode: same fix pattern
This commit is contained in:
@@ -27,6 +27,10 @@ public class DashboardWebSocketEndpoint {
|
|||||||
public String onMessage(String message, WebSocketConnection connection) {
|
public String onMessage(String message, WebSocketConnection connection) {
|
||||||
LOG.debugf("WebSocket message received from %s: %s", connection.id(), message);
|
LOG.debugf("WebSocket message received from %s: %s", connection.id(), message);
|
||||||
|
|
||||||
|
if (message == null) {
|
||||||
|
return "{\"type\":\"ack\",\"data\":{\"received\":true}}";
|
||||||
|
}
|
||||||
|
|
||||||
// Répondre aux pings avec un pong (heartbeat)
|
// Répondre aux pings avec un pong (heartbeat)
|
||||||
if ("ping".equalsIgnoreCase(message.trim()) || message.contains("\"type\":\"ping\"")) {
|
if ("ping".equalsIgnoreCase(message.trim()) || message.contains("\"type\":\"ping\"")) {
|
||||||
return "{\"type\":\"pong\",\"data\":{\"timestamp\":" + System.currentTimeMillis() + "}}";
|
return "{\"type\":\"pong\",\"data\":{\"timestamp\":" + System.currentTimeMillis() + "}}";
|
||||||
|
|||||||
@@ -103,10 +103,23 @@ class ConversationParticipantTest {
|
|||||||
@DisplayName("equals et hashCode")
|
@DisplayName("equals et hashCode")
|
||||||
void equalsHashCode() {
|
void equalsHashCode() {
|
||||||
UUID id = UUID.randomUUID();
|
UUID id = UUID.randomUUID();
|
||||||
ConversationParticipant a = buildMinimal("PARTICIPANT");
|
// Partage les mêmes Conversation et Membre pour que Lombok equals
|
||||||
|
// sur les champs imbriqués donne true (les IDs imbriqués sont aléatoires
|
||||||
|
// dans newConversation/newMembre, donc il faut réutiliser les instances).
|
||||||
|
Conversation sharedConv = newConversation();
|
||||||
|
Membre sharedMembre = newMembre();
|
||||||
|
ConversationParticipant a = new ConversationParticipant();
|
||||||
a.setId(id);
|
a.setId(id);
|
||||||
ConversationParticipant b = buildMinimal("PARTICIPANT");
|
a.setConversation(sharedConv);
|
||||||
|
a.setMembre(sharedMembre);
|
||||||
|
a.setRoleDansConversation("PARTICIPANT");
|
||||||
|
a.setNotifier(true);
|
||||||
|
ConversationParticipant b = new ConversationParticipant();
|
||||||
b.setId(id);
|
b.setId(id);
|
||||||
|
b.setConversation(sharedConv);
|
||||||
|
b.setMembre(sharedMembre);
|
||||||
|
b.setRoleDansConversation("PARTICIPANT");
|
||||||
|
b.setNotifier(true);
|
||||||
assertThat(a).isEqualTo(b);
|
assertThat(a).isEqualTo(b);
|
||||||
assertThat(a.hashCode()).isEqualTo(b.hashCode());
|
assertThat(a.hashCode()).isEqualTo(b.hashCode());
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -143,10 +143,23 @@ class MessageTest {
|
|||||||
@DisplayName("equals et hashCode")
|
@DisplayName("equals et hashCode")
|
||||||
void equalsHashCode() {
|
void equalsHashCode() {
|
||||||
UUID id = UUID.randomUUID();
|
UUID id = UUID.randomUUID();
|
||||||
Message a = buildMinimal(TypeContenu.TEXTE);
|
// Partage Conversation et Membre pour que Lombok equals
|
||||||
|
// (récursif sur les champs) donne true — sinon les UUIDs aléatoires
|
||||||
|
// dans newConversation/newMembre cassent l'égalité.
|
||||||
|
Conversation sharedConv = newConversation();
|
||||||
|
Membre sharedExpediteur = newMembre();
|
||||||
|
Message a = new Message();
|
||||||
a.setId(id);
|
a.setId(id);
|
||||||
Message b = buildMinimal(TypeContenu.TEXTE);
|
a.setConversation(sharedConv);
|
||||||
|
a.setExpediteur(sharedExpediteur);
|
||||||
|
a.setTypeMessage(TypeContenu.TEXTE);
|
||||||
|
a.setContenu("Texte test");
|
||||||
|
Message b = new Message();
|
||||||
b.setId(id);
|
b.setId(id);
|
||||||
|
b.setConversation(sharedConv);
|
||||||
|
b.setExpediteur(sharedExpediteur);
|
||||||
|
b.setTypeMessage(TypeContenu.TEXTE);
|
||||||
|
b.setContenu("Texte test");
|
||||||
assertThat(a).isEqualTo(b);
|
assertThat(a).isEqualTo(b);
|
||||||
assertThat(a.hashCode()).isEqualTo(b.hashCode());
|
assertThat(a.hashCode()).isEqualTo(b.hashCode());
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user